Skip to content

libp2p -> zenoh#2132

Merged
Evanev7 merged 3 commits into
mainfrom
zenoh3
Jun 3, 2026
Merged

libp2p -> zenoh#2132
Evanev7 merged 3 commits into
mainfrom
zenoh3

Conversation

@Evanev7
Copy link
Copy Markdown
Member

@Evanev7 Evanev7 commented May 31, 2026

supercedes #2076 and #2073

Copy link
Copy Markdown
Collaborator

@AndreiCravtov AndreiCravtov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good; there are regressions vs. main branch (mostly undoing some changes I pushed to main) that need to be fixed.

I offer to fix many of the issues/comments I raised to begin with lol, if you're fine with that

Comment thread rust/exo_rs/src/ident.rs Outdated
Comment thread rust/exo_rs/src/ident.rs Outdated
Comment thread rust/exo_rs/src/pidfile.rs Outdated
Comment thread rust/exo_rs/src/networking.rs Outdated
Comment thread rust/exo_rs/src/networking.rs
Comment thread rust/networking/src/discovery.rs
Comment thread rust/networking/src/swarm.rs Outdated
Comment thread rust/networking/src/swarm.rs Outdated
Comment thread rust/networking/src/swarm.rs Outdated
Comment thread rust/networking/src/lib.rs Outdated
@AndreiCravtov AndreiCravtov self-requested a review June 3, 2026 00:49
Copy link
Copy Markdown
Collaborator

@AndreiCravtov AndreiCravtov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - that addresses all my concerns

nice one

IMPORTANT: just add somewhere in docs that bootstrap peers has been temporarily broken

@Evanev7 Evanev7 force-pushed the zenoh3 branch 2 times, most recently from 649904e to 3ffc977 Compare June 3, 2026 01:18
@Evanev7
Copy link
Copy Markdown
Member Author

Evanev7 commented Jun 3, 2026

added to TODO.md

Copy link
Copy Markdown
Collaborator

@AndreiCravtov AndreiCravtov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Evanev7 Evanev7 merged commit 09f9ea3 into main Jun 3, 2026
6 checks passed
@Evanev7 Evanev7 deleted the zenoh3 branch June 3, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants